neilconway commented on code in PR #11187: URL: https://github.com/apache/arrow-rs/pull/11187#discussion_r4106853282
########## arrow-arith/src/temporal.rs: ########## @@ -184,6 +184,10 @@ where /// Returns an [`Int32Array`] unless input was a dictionary type, in which case returns /// the dictionary but with this function applied onto its values. /// +/// Null inputs produce null outputs. A timestamp outside the supported calendar +/// range also produces null, except that for timestamps without a timezone the +/// time parts (`Hour` through `Nanosecond`) are defined for every value. Review Comment: Cool. The current PR has documentation that seems sufficient to me, but lmk if you have suggestions for other places to document this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
