singhpratech opened a new pull request, #1338: URL: https://github.com/apache/arrow-go/pull/1338
Follow-up to #1336, docs only. The review noted two things worth a sentence in the comments: - `MergeAll` returns `(nil, nil)` for an empty `states` slice, and a caller reading "returns the state you then finalize" could finalize nil. The comment now says so, and says what to do instead: aggregate the empty input the way the executor does, one state from init, then finalize. - `Ordered` has no effect on the in-tree executor, which consumes the whole input into a single state in order. The comment now says that it is a contract for `MergeAll` and for callers that partition the input themselves. No code change. `gofmt`, `go vet` and `go test` on `arrow/compute` and `arrow/compute/exec` are clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
