neilconway commented on PR #11219: URL: https://github.com/apache/arrow-rs/pull/11219#issuecomment-5846739413
@Jefffrey Ah, thanks for flagging that! My mistake, I didn't see the previous PR. Comparing the two approaches, my two cents: * I think either PR is an improvement over the status quo * I don't see a good reason to go through `AsPrimitive::as_`, which risks the behavior of the two code paths diverging. It also means that #10958 doesn't support f64 -> f32 and anything -> f16, whereas this PR supports those. * In #10958, the predicate to check if we should take the fast-path _should_ be const-folded away by LLVM (and it is today), but in this PR, that is enforced by the compiler. cc @Rich-T-kid @alexeigor -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
