rossoha opened a new pull request, #862:
URL: https://github.com/apache/arrow-rs-object-store/pull/862
Adds a backend-neutral API for compare-and-swap deletes:
delete object
ONLY IF
current object version == expected version
Conditional delete provides optimistic concurrency control. A backend that
supports the supplied precondition performs the check atomically with the
deletion, as part of a single conditional request, and must not emulate it with
a separate metadata read followed by an unconditional delete.
- `DeleteOptions::precondition: Option<UpdateVersion>` reuses the existing
version identity model (`e_tag` + `version`) rather than introducing a second
one, and a `From<ObjectMeta>` impl is added for ergonomics
- `ObjectStore::delete_opts` has a default implementation returning
`NotSupported` for preconditions, so existing implementations keep compiling;
`ObjectStoreExt::delete` now delegates to it with default options, preserving
existing behavior (including S3's bulk `DeleteObjects`)
- GCS uses `x-goog-if-generation-match` (generation), S3 and Azure use
`If-Match` (ETag); `InMemory` checks and removes under the same lock
- Backends that cannot evaluate the precondition report `NotSupported` /
`NotImplemented`, so callers can fall back to an unconditional delete
- `ObjectStore::delete_opts` is forwarded through the `Arc`/`Box` and
wrapper (`ChunkedStore`, `LimitStore`, `PrefixStore`, `ThrottledStore`)
implementations
- Covered by trait-level integration tests and by request-shape unit tests
for GCS/S3/Azure; verified against Azurite (Azure) and LocalStack (S3 reports
`501` and is skipped)
Addresses #298
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please call them out.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
