sdf-jkl opened a new pull request, #11253:
URL: https://github.com/apache/arrow-rs/pull/11253
# Which issue does this PR close?
Follow-up to #10357; corrects the benchmark used by #10358.
# Rationale for this change
The unshredded object fixture has a literal field named `attr.140`, but
`VariantPath::try_from("attr.140")` parses it as two nested fields (`attr` then
`140`). Since the fixture has no `attr` field, the benchmark returns NULL for
every row instead of extracting the intended value.
# What changes are included in this PR?
Construct the path with `VariantPathElement::field("attr.140")` and assert
that every result is `Some(140)` before entering the timed loop.
# Are these changes tested?
- `cargo bench --offline -p parquet-variant-compute --bench variant_kernels
-- variant_get_unshredded_object_path_262k_rows --test`
- `cargo fmt --all -- --check`
- `git diff --check`
# Are there any user-facing changes?
No. This only corrects the benchmark workload; previous timings for this
benchmark measured missing-path handling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
