kita-renji commented on PR #11224: URL: https://github.com/apache/arrow-rs/pull/11224#issuecomment-5871880647
@Cintu07 sorry. You said in the issue you were happy to take the PR once the split vs. fail question was settled, and I went ahead without checking with you first. I should have asked. @Jefffrey thanks for the review. I've addressed the three comments and also lowered the bound to i32::MAX, since the spec says view offsets are signed and gc() already caps buffers there. I agree splitting across buffers is the better end state. gc_with_max_buffer_size` already does something similar. Would you rather have that here, or merge the explicit error now and do the split as a follow-up? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
