HippoBaro commented on PR #11266: URL: https://github.com/apache/arrow-rs/pull/11266#issuecomment-5883108973
> Thanks @HippoBaro, long time no see 👋. Thanks @etseidl, good to be back! > Maybe I'm missing something, but I think rather than adding the new validation function (which to me seems like a maintenance headache), why don't we just add type checking to `get_encoder` implementations? Agreed. I’ve removed the separate validator and moved the physical-type checks into the existing encoder factory matches. I’ve also strengthened the tests to check factory errors directly, alongside the column-construction matrix covering both writer versions and dictionary settings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
