haohuaijin opened a new pull request, #11292: URL: https://github.com/apache/arrow-rs/pull/11292
# Which issue does this PR close? Follow-up to the [review discussion in #10859](https://github.com/apache/arrow-rs/pull/10859#discussion_r4123432144). # Rationale for this change `ReadPlanBuilder::resolve_selection_strategy` only forwards to `RowSelectionPolicy::resolve`. Remove this extra layer of indirection without changing how the row selection strategy is chosen. # What changes are included in this PR? - Call `RowSelectionPolicy::resolve` directly when building a read plan and preparing page skipping in the push decoder. - Remove the forwarding method, update existing tests, and move the now test-only `RowSelectionStrategy` import into the test module. # Are these changes tested? All 20 existing tests in the two affected modules pass: - `cargo test -p parquet --lib arrow::arrow_reader::read_plan::tests` (13 tests) - `cargo test -p parquet --lib arrow::push_decoder::reader_builder::tests` (7 tests) `cargo fmt --all -- --check` and `git diff --check` also pass. # Are there any user-facing changes? No. This is an internal refactor with no public API or behavior changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
