westonpace commented on pull request #10258: URL: https://github.com/apache/arrow/pull/10258#issuecomment-847445822
Also, I ran into a bit of trouble with the future callback's weak reference to the future. Before we could just assume it was valid since all callbacks were completed before `MarkFinished` was completed. Now, it is possible for a future to schedule a callback and that callback to far outlive the call to `MarkFinished`. So now when a callback is scheduled (run on an executor) we make a copy of the `FutureImpl`'s shared_ptr to keep it alive until that callback has a chance to run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
