etseidl commented on code in PR #11157:
URL: https://github.com/apache/arrow-rs/pull/11157#discussion_r4146203784


##########
parquet/src/file/metadata/reader.rs:
##########
@@ -108,6 +117,191 @@ impl From<bool> for PageIndexPolicy {
     }
 }
 
+/// Struct to specify column chunks for which metadata is required.
+///
+/// Column chunks are identified by row group index and leaf column index (the 
index of the
+/// column in [`SchemaDescriptor::columns`], not the index of a root or Arrow 
field). This struct
+/// allows for specifying vertical slices of column chunk data (via 
[`Self::columns`]),
+/// horizontal slices (via [`Self::row_groups`]), or the intersection of the 
two
+/// (via [`Self::row_groups_and_columns`]).
+///
+/// At present this is only used to select elements of the [Page Index] for 
decoding.

Review Comment:
   While we're on cloning, if you have a moment to opine on #11297 I'd 
appreciate your thoughts.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to