Copilot commented on code in PR #51661:
URL: https://github.com/apache/arrow/pull/51661#discussion_r4152790400
##########
cpp/src/parquet/reader_test.cc:
##########
@@ -1124,6 +1124,11 @@ class TestJSONWithLocalFile : public ::testing::Test {
};
TEST_F(TestJSONWithLocalFile, JSONOutputWithStatistics) {
+ // simdjson 5.0 changed the format of fractured_json
+ if constexpr (simdjson::SIMDJSON_VERSION_MAJOR < 5) {
+ GTEST_SKIP() << "Test requires simdjson >= 5";
+ }
Review Comment:
This disables the four formatting assertions for simdjson 4.x instead of
preserving their previous expectations as the PR describes. In particular,
Arrow still pins bundled simdjson to v4.6.4
(`cpp/thirdparty/versions.txt:105`), so bundled builds will silently skip all
four tests. Please retain the old expected strings for `< 5` and select the new
strings only for `>= 5` rather than skipping the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
