efegokdemir commented on code in PR #4815:
URL: https://github.com/apache/arrow-adbc/pull/4815#discussion_r4159004501
##########
csharp/src/Apache.Arrow.Adbc/DriverManager/AdbcDriverManager.cs:
##########
@@ -132,7 +134,12 @@ private static AdbcDriver LoadNativeDriver(string
driverPath, string? entrypoint
typeName: null,
manifestPath: null,
loadMethod: loadMethod,
- () => CAdbcDriverImporter.Load(driverPath,
resolvedEntrypoint));
+ () => entrypoint == null
+ ? CAdbcDriverImporter.LoadWithFallback(
+ driverPath,
+ resolvedEntrypoint,
+ DefaultNativeEntrypoint)
+ : CAdbcDriverImporter.Load(driverPath,
resolvedEntrypoint));
Review Comment:
Fixed in bf4091f8. LoadFromManifest now preserves entrypoint provenance:
filename-derived entrypoints use LoadWithFallback(..., AdbcDriverInit), while
caller- and manifest-explicit entrypoints remain strict through Load. Added an
AOT FindLoadDriver regression using a manifest without [Driver].entrypoint.
Local git diff --check passes; the local environment has no dotnet SDK, so .NET
tests remain CI-only.
##########
csharp/test/AotInterop/Apache.Arrow.Adbc.TestFixture.Tests/AotFixtureTests.cs:
##########
@@ -63,6 +63,32 @@ public void DriverNegotiatesV1_1_0()
Assert.Equal(AdbcVersion.Version_1_1_0, driver.DriverVersion);
}
+ [SkippableFact]
+ public void DriverManagerFallsBackToStandardEntrypoint()
+ {
+ string fixturePath = ResolveFixturePath()!;
+ string directory =
Path.Combine(Path.GetDirectoryName(fixturePath)!, Guid.NewGuid().ToString("N"));
Review Comment:
Fixed in bf4091f8. The AOT tests now call Skip.IfNot through a shared
fixture guard before dereferencing the resolved path, and also validate the
manifest-based FindLoadDriver fallback path. Local git diff --check passes; the
local environment has no dotnet SDK, so the AOT test execution remains CI-only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
