neilconway opened a new pull request, #11327: URL: https://github.com/apache/arrow-rs/pull/11327
# Which issue does this PR close? - Relates to #3972 # Rationale for this change `PrimitiveDictionaryBuilder::finish_cloned` and `finish_preserve_values` built the dictionary with `V::DATA_TYPE`, which is the default `DataType` for the dictionary's value type. This loses type parameters, like the scale/precision of a decimal value. A similar bug was fixed for `finish` in #3972, but `finish_cloned` and `finish_preserve_values` was missed. # What changes are included in this PR? See above. # Are these changes tested? Yes; existing tests pass, test expanded to cover this behavior. Verified that the updated test fails without the behavior change. # Are there any user-facing changes? No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
