Copilot commented on code in PR #51686:
URL: https://github.com/apache/arrow/pull/51686#discussion_r4163689893
##########
cpp/src/parquet/reader_test.cc:
##########
@@ -1124,6 +1124,11 @@ class TestJSONWithLocalFile : public ::testing::Test {
};
TEST_F(TestJSONWithLocalFile, JSONOutputWithStatistics) {
+ // simdjson 5.0 changed the format of fractured_json
+ if constexpr (simdjson::SIMDJSON_VERSION_MAJOR < 5) {
+ GTEST_SKIP() << "Test requires simdjson >= 5";
+ }
Review Comment:
This skips four pre-existing output assertions for Arrow's default vendored
simdjson 4.6.4, so bundled builds lose their JSON-format regression coverage.
Please retain the previous expectations for versions below 5 and select the
expected formatting by simdjson version rather than skipping these tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
