Jefffrey commented on code in PR #11078:
URL: https://github.com/apache/arrow-rs/pull/11078#discussion_r4166100723
##########
arrow-cast/src/cast/mod.rs:
##########
@@ -81,20 +84,6 @@ pub use decimal::parse_string_to_decimal_native;
pub use decimal::{DecimalCast, rescale_decimal, single_float_to_decimal};
pub use string::cast_single_string_to_boolean_default;
-/// Lossy conversion from decimal to float.
-///
-/// Conversion is lossy and follows standard floating point semantics. Values
-/// that exceed the representable range become `INFINITY` or `-INFINITY`
without
-/// returning an error.
-#[inline(always)]
-pub fn single_decimal_to_float_lossy<D, F>(f: &F, x: D::Native, scale: i32) ->
f64
Review Comment:
for this id prefer to leave it here, since its a public function and its
small enough anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
