lidavidm commented on a change in pull request #10390: URL: https://github.com/apache/arrow/pull/10390#discussion_r638935508
########## File path: cpp/src/arrow/compute/api_scalar.h ########## @@ -42,6 +42,11 @@ struct ArithmeticOptions : public FunctionOptions { bool check_overflow; }; +struct ARROW_EXPORT MinMaxOptions : public FunctionOptions { Review comment: Since we have `ScalarAggregateOptions` I think `ElementWiseAggregateOptions` should be ok. I've updated the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org