etseidl commented on code in PR #11051:
URL: https://github.com/apache/arrow-rs/pull/11051#discussion_r4170217462
##########
parquet/src/encodings/encoding/mod.rs:
##########
@@ -125,17 +140,30 @@ pub(crate) mod private {
physical_type => return
Err(unsupported_column_encoding(encoding, physical_type)),
},
Encoding::DELTA_BINARY_PACKED => match T::get_physical_type() {
- Type::INT32 | Type::INT64 =>
Box::new(DeltaBitPackEncoder::new()),
+ Type::INT32 | Type::INT64 => Box::new(
+ match options.and_then(|props|
props.delta_binary_packed_encoder_options) {
+ Some(options) =>
DeltaBitPackEncoder::new_with_options(options),
+ None => DeltaBitPackEncoder::new(),
+ },
Review Comment:
I was thinking it would be nice to just pass the
`Option<&ResolvedColumnProperties>` straight into `new`, but when I tried that
there was quite the ripple through the tests and such. Not sure it's worth the
pain. Plus there's the quasi public nature of the encoder module...it's public
but hidden, so I guess technically not part of the public API, but I think this
is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
