cakeni commented on code in PR #10636: URL: https://github.com/apache/arrow-rs/pull/10636#discussion_r4171865564
########## arrow-array/src/builder/struct_array_assembler.rs: ########## @@ -0,0 +1,162 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use crate::{ArrayRef, StructArray}; +use arrow_buffer::NullBuffer; +use arrow_schema::{ArrowError, Field, FieldRef, Fields}; +use std::sync::Arc; + +/// Builds a [`StructArray`] from completed child arrays. +/// +/// Unlike [`StructBuilder`](super::StructBuilder), which incrementally builds Review Comment: Added a note on `StructBuilder` pointing to `StructArrayAssembler` for already-built child arrays. ########## arrow-array/src/builder/struct_array_assembler.rs: ########## @@ -0,0 +1,162 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use crate::{ArrayRef, StructArray}; +use arrow_buffer::NullBuffer; +use arrow_schema::{ArrowError, Field, FieldRef, Fields}; +use std::sync::Arc; + +/// Builds a [`StructArray`] from completed child arrays. +/// +/// Unlike [`StructBuilder`](super::StructBuilder), which incrementally builds +/// child arrays, this builder assembles arrays that have already been built. +/// +/// # Example +/// +/// ``` +/// use std::sync::Arc; +/// use arrow_array::builder::StructArrayBuilder; +/// use arrow_array::{Array, ArrayRef, Int32Array, StringArray}; +/// Review Comment: Prefixed the example imports with `#`. ########## arrow-array/src/builder/struct_array_builder.rs: ########## @@ -0,0 +1,162 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use crate::{ArrayRef, StructArray}; +use arrow_buffer::NullBuffer; +use arrow_schema::{ArrowError, Field, FieldRef, Fields}; +use std::sync::Arc; + +/// Builds a [`StructArray`] from completed child arrays. +/// +/// Unlike [`StructBuilder`](super::StructBuilder), which incrementally builds +/// child arrays, this builder assembles arrays that have already been built. +/// +/// # Example +/// +/// ``` +/// use std::sync::Arc; +/// use arrow_array::builder::StructArrayBuilder; +/// use arrow_array::{Array, ArrayRef, Int32Array, StringArray}; +/// +/// let names = Arc::new(StringArray::from(vec!["one", "two"])) as ArrayRef; +/// let values = Arc::new(Int32Array::from(vec![1, 2])) as ArrayRef; +/// let array = StructArrayBuilder::new() Review Comment: Added the `{name, value}` row comment to the example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
