rluvaton commented on code in PR #11324:
URL: https://github.com/apache/arrow-rs/pull/11324#discussion_r4178192820
##########
arrow-ord/src/partition.rs:
##########
@@ -166,6 +169,46 @@ fn find_boundaries(v: &dyn Array) -> Result<BooleanBuffer,
ArrowError> {
Ok((0..slice_len).map(|i| !cmp(i, i).is_eq()).collect())
}
+fn convert_boolean_buffer_to_builder(buffer: BooleanBuffer) ->
BooleanBufferBuilder {
+ let len = buffer.len();
+
+ // This should be 0, but in case it doesn't simplify the code by doing a
copy to a new buffer
Review Comment:
The builder have no notion of offset
The offset is only for slicing immutable buffers and you need to slice bit
wise and not byte wise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
