rustyconover commented on PR #928: URL: https://github.com/apache/arrow-nanoarrow/pull/928#issuecomment-5986860481
Thanks for the thorough review! I've split this as you suggested: - **#955**: decoding dictionary delta batches (decoder only). - **This PR**: not re-emitting unchanged dictionaries (now by buffer address), plus the encoder and writer fixes for nested dictionaries, `DICTIONARY_REPLACEMENT`, dictionary batch metadata and file mode. It is rebuilt from current `main` and contains no decoder or delta changes. - **Delta emission in the writer** is dropped, per your comment that this belongs in application code. The existing `ArrowIpcWriterWriteDictionaryBatch(..., is_delta = 1, ...)` covers that. The two PRs are independent and can be reviewed and merged in either order. I've replied to each inline comment with where it was addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
