Dandandan commented on a change in pull request #375:
URL: https://github.com/apache/arrow-datafusion/pull/375#discussion_r639027601
##########
File path: datafusion/tests/sql.rs
##########
@@ -797,20 +797,30 @@ async fn csv_query_count() -> Result<()> {
Ok(())
}
-// FIXME uncomment this when exec is done
-// #[tokio::test]
-// async fn csv_query_window_with_empty_over() -> Result<()> {
-// let mut ctx = ExecutionContext::new();
-// register_aggregate_csv(&mut ctx)?;
-// let sql = "SELECT count(c12) over () FROM aggregate_test_100";
-// // FIXME: so far the WindowAggExec is not implemented
-// // and the current behavior is to throw not implemented exception
-
-// let result = execute(&mut ctx, sql).await;
-// let expected: Vec<Vec<String>> = vec![];
-// assert_eq!(result, expected);
-// Ok(())
-// }
+#[tokio::test]
+async fn csv_query_window_with_empty_over() -> Result<()> {
+ let mut ctx = ExecutionContext::new();
+ register_aggregate_csv(&mut ctx)?;
+ let sql = "select \
+ c2, \
+ row_number() over (),
+ sum(c3) over (), \
+ avg(c3) over (), \
+ count(c3) over (), \
+ max(c3) over (), \
+ min(c3) over () \
+ from aggregate_test_100 limit 5";
Review comment:
I think an explicit order by is required (or sorting of results) to make
this deterministic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
