Copilot commented on code in PR #4860: URL: https://github.com/apache/arrow-adbc/pull/4860#discussion_r4191767687
########## c/driver/sqlite/sqlite.cc: ########## @@ -34,15 +34,38 @@ #include "driver/sqlite/config.h" #include "driver/sqlite/statement_reader.h" +// Account for old versions of SQLite and macOS annoyances #if SQLITE_VERSION_NUMBER < 3037000 +#define POLYFILL_SQLITE_CHANGES +#elif defined(HAVE_BUILTIN_AVAILABLE) +#if !__builtin_available(macOS 12.3, *) Review Comment: This does not enable the macOS fallback: `HAVE_BUILTIN_AVAILABLE` is not defined by either SQLite build configuration, so the branch is skipped, and if it were defined Clang rejects `__builtin_available(...)` in a preprocessor expression. Consequently the wrapper still compiles an unguarded `sqlite3_total_changes64` call and the reported macOS 10.15 build error remains. Move the availability check into the wrapper function (or select the fallback with the macOS deployment-target macro). This issue also appears on line 48 of the same file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
