Jefffrey opened a new issue, #11397:
URL: https://github.com/apache/arrow-rs/issues/11397

   ### Is your feature request related to a problem or challenge?
   
   - followup to https://github.com/apache/arrow-rs/pull/10509
   
   ### Describe the solution you'd like
   
   
https://github.com/apache/arrow-rs/blob/cb3bec2362d8a1fb98ca1114f6bd0626ce8ec428/arrow-cast/src/cast/mod.rs#L120-L143
   
   - these functions are fallbacks which rely on string parsing; look to duckdb 
in how it parses by digit instead of via strings: 
https://github.com/duckdb/duckdb/pull/22874
   - see https://github.com/apache/arrow-rs/pull/10509#discussion_r3702323157
   
   
https://github.com/apache/arrow-rs/blob/cb3bec2362d8a1fb98ca1114f6bd0626ce8ec428/arrow-cast/src/cast/mod.rs#L163-L181
   
   - here inside the cast hot loop we need to check against an upper limit to 
decide which path to take; we should try to optimize this if possible, e.g. 
check up front if there are any such values otherwise we can do a faster path 
without this branching
   - see https://github.com/apache/arrow-rs/pull/10509#discussion_r4190618782
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to