pitrou commented on code in PR #51705:
URL: https://github.com/apache/arrow/pull/51705#discussion_r4192739481
##########
cpp/src/parquet/printer.cc:
##########
@@ -167,7 +167,6 @@ void ParquetFilePrinter::DebugPrint(std::ostream& stream,
std::list<int> selecte
}
stream << " Values: " << column_chunk->num_values();
if (column_chunk->is_stats_set()) {
- std::string min = stats->min(), max = stats->max();
std::string max_exact =
Review Comment:
It's not useful computing this when it's not being used, let's move it below?
##########
cpp/src/parquet/reader_test.cc:
##########
@@ -568,6 +568,38 @@ TEST_F(TestAllTypesPlain, DebugPrintWorks) {
ASSERT_GT(result.size(), 0);
}
+TEST(TestDebugPrintWithMemoryFile, AllNullDecimalStatistics) {
Review Comment:
Add a short comment linking to issue and explaining what this test is about?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
