kentkwu opened a new pull request, #500:
URL: https://github.com/apache/arrow-js/pull/500

   ## What's Changed
   
   getVisitFn used `instanceof DataType`, which fails for a type created by 
another copy of the library, such as the CommonJS and ES module builds loaded 
side by side. The visitor fell through to `Type.NONE`, so the IPC writer 
silently wrote a stream with no types and empty bodies.
   
   Applies a fix to use `DataType.isDataType()` introduced in #377, which works 
across copies, and adds a test that writes tables through a second copy of the 
library.
   
   Closes  #496


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to