Mandukhai-Alimaa commented on code in PR #4852:
URL: https://github.com/apache/arrow-adbc/pull/4852#discussion_r4202055677
##########
c/driver/postgresql/validation/tests/test_query.py:
##########
@@ -25,4 +32,67 @@
def pytest_generate_tests(metafunc) -> None:
vendor = metafunc.config.getoption("vendor")
- return generate_tests([postgresql.get_quirks(vendor)], metafunc)
+ quirks = [postgresql.get_quirks(vendor)]
+ if not metafunc.definition.name.startswith("test_hypothesis_"):
+ return generate_tests(quirks, metafunc)
+ return adbc_drivers_validation.utils.generate_tests_by_marks(quirks,
metafunc)
+
+
[email protected]
+def st_decimal_precision_scale(draw) -> tuple[int, int]:
+ precision = draw(st.integers(min_value=1, max_value=38))
+ # TODO: we should also test negative scales
+ scale = draw(st.integers(min_value=0, max_value=min(precision, 37)))
+ return precision, scale
Review Comment:
this seems not used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
