mag1cfrog opened a new pull request, #872:
URL: https://github.com/apache/arrow-rs-object-store/pull/872

   # Which issue does this PR close?
   
   Closes #871.
   
   # Rationale for this change
   
   Virtual-hosted S3 HTTPS URLs with bucket names starting with `s3` lose the 
first object-key segment. For example, `table/file.parquet` becomes 
`file.parquet`.
   
   # What changes are included in this PR?
   
   - Exclude virtual-hosted S3 URLs from the path-style bucket-stripping branch.
   - Add seven test cases covering regional, global, and dual-stack URLs, 
single-segment keys, and a path-style control.
   
   The regression test fails on main and passes with the fix.
   
   # Are there any user-facing changes?
   
   Affected URLs now preserve the complete object key. No public API changes.
   
   **Validation**
   
   - `cargo test --features=aws,azure,gcp,http` (live-service integration tests 
disabled)
   - `cargo clippy --all-features --all-targets -- -D warnings`
   - `cargo fmt --all -- --check`
   
   Codex assisted with the fix and regression tests. I reviewed the changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to