jeroen opened a new pull request, #52023:
URL: https://github.com/apache/arrow/pull/52023

   ### Rationale for this change
   
   xsimd 14.2.0 includes the MSVC-only `<arm64_neon.h>` header whenever 
`_WIN32` and NEON64 are defined:
   
   ```cpp
   #if defined(_WIN32) && XSIMD_WITH_NEON64
   #include <arm64_neon.h>
   ```
   
   `_WIN32` is also defined by mingw-w64 toolchains (e.g. MSYS2 clangarm64, 
llvm-mingw), which do not provide `<arm64_neon.h>`, so building Arrow C++ for 
Windows aarch64 with such a toolchain fails on the missing header. xsimd 14.3.0 
narrows the condition to `defined(_MSC_VER) && !defined(__clang__)`, so 
mingw-w64 builds use `<arm_neon.h>`.
   
   We currently work around this in the R Windows toolchain 
(https://github.com/r-windows/ucrt-libs) by patching `versions.txt` to 14.3.0 
before building Arrow.
   
   ### What changes are included in this PR?
   
   Bump `ARROW_XSIMD_BUILD_VERSION` and `ARROW_XSIMD_BUILD_SHA256_CHECKSUM` in 
`cpp/thirdparty/versions.txt` to xsimd 14.3.0. I left the minimum required 
version for system xsimd (`14.2.0` in `ThirdpartyToolchain.cmake`) unchanged, 
since the issue only affects the bundled build.
   
   ### Are these changes tested?
   
   Not run locally; relying on CI to verify that Arrow still builds and passes 
tests against xsimd 14.3.0. The checksum was computed from 
`https://github.com/xtensor-stack/xsimd/archive/14.3.0.tar.gz`. The same 
version also builds Arrow 26.0.0-rc0 for us on the R Windows toolchain.
   
   ### Are there any user-facing changes?
   
   No.
   
   * GitHub Issue: #52022


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to