Arawoof06 commented on PR #1262: URL: https://github.com/apache/arrow-java/pull/1262#issuecomment-6044059053
Both points are right, and both are on main now. #1309 landed the range check on the `long` before the narrowing cast, and switched `StructSubfieldEncoder` to pass `dictionary.getVector().getValueCount()` instead of the struct row count. That is what you asked for here, including the 64-bit wrap case I had missed, and my description was wrong to claim the struct path fell out of the one-line change. I checked the three `retrieveIndexVector` callers on main and they all pass the dictionary's own value count now, so this branch has nothing left to contribute. Fine to close it as superseded by #1309. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
