sdf-jkl commented on PR #11403: URL: https://github.com/apache/arrow-rs/pull/11403#issuecomment-6065330054
Hi @osipovartem, I'd like to have a bench for this change as well. It seems like we already have some benchmarks that can partially cover the changed behavior, but they not targeted enough and require a Validation toggle https://github.com/apache/arrow-rs/blob/9c07b17255ee65a70c1885368c1d91ca737521de/parquet-variant/benches/variant_builder.rs#L94-L112 or time smth else entirely https://github.com/apache/arrow-rs/blob/9c07b17255ee65a70c1885368c1d91ca737521de/parquet-variant/benches/variant_builder.rs#L390-L400 I think adding a small bench timing the ObjectBuilder::insert with validation on and off should do -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
