alamb commented on code in PR #11433:
URL: https://github.com/apache/arrow-rs/pull/11433#discussion_r4222376660
##########
arrow-data/src/data.rs:
##########
@@ -688,6 +688,22 @@ impl ArrayData {
///
/// Panics if `offset + length` overflows or is greater than `self.len()`.
pub fn slice(&self, offset: usize, length: usize) -> ArrayData {
+ self.clone().sliced(offset, length)
Review Comment:
it is pretty minor but this could call `slice_in_place` and skip a function
call in sliced
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
