fboudra commented on PR #51372:
URL: https://github.com/apache/arrow/pull/51372#issuecomment-6068388795

   > @fboudra can you indicate more precisely what this PR contains compared to 
#50409. Are this all the source code changes from that PR (which already got 
some review rounds), just with the other changes removed (the benchmark 
removal)?
   
   @jorisvandenbossche The comment 
https://github.com/apache/arrow/pull/50409#issuecomment-5712871976 explains why 
I splitted into multiple PRs in an attempt to make it easier to review. The 
last PR #51377 has all the patches in the serie (33 patches in total).
   
   The full PR (#51377) contains all of the source changes from #50409, the 
benchmark removal included, plus 20 new commits on top.
   
   The first 13 commits are the 13 non-merge commits from #50409, cherry-picked 
onto current main. The five Merge upstream/main commits from #50409 are gone 
because this branch is rebased instead.
   
   The benchmark removal is kept (Remove 
python/pyarrow/src/arrow/python/benchmark.cc, Remove pyarrow.benchmark). It's a 
prerequisite for the limited-API build, so I didn't drop it.
   
   The 20 extra commits are work that isn't in #50409 (the limited-API port is 
incomplete):
   - finishing the limited-API port: the remaining macro fast paths, 
PyGILState_Check → Py_IsInitialized, the datetime C-API via the capsule, 
vendored pythoncapi_compat fixes, refcount and stable-ABI semantics fixes, and 
cp311 compat fixes for Py_REFCNT and PyObject_CallFunction('s#')
   - enabling the abi3 build: Py_LIMITED_API=0x030B0000 on arrow_python, Cython 
--limited-api, .abi3.so module suffix
   - packaging and CI: the limited-API symbol audit script, the cp311-abi3 
wheel matrix, and the perf gate
   
   So the reviewed changes from #50409 are all here unchanged. If it helps, I 
can keep #50409 open for the conversions and rebase this PR onto it, so the new 
work gets reviewed separately.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to