ritchie46 commented on pull request #341:
URL: https://github.com/apache/arrow-rs/pull/341#issuecomment-848485729
> Do we have some benchmarks available? It would be good to verify that the
performance improves here.
```
Gnuplot not found, using plotters backend
all true str 10k time: [202.99 ns 203.24 ns 203.59 ns]
change: [-99.808% -99.807% -99.807%] (p = 0.00 <
0.05)
Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
5 (5.00%) high mild
3 (3.00%) high severe
all true int 10k time: [187.96 ns 188.03 ns 188.09 ns]
change: [-98.627% -98.625% -98.623%] (p = 0.00 <
0.05)
Performance has improved.
Found 14 outliers among 100 measurements (14.00%)
1 (1.00%) low severe
1 (1.00%) high mild
12 (12.00%) high severe
all false str 10k time: [323.02 ns 323.13 ns 323.25 ns]
change: [-66.262% -64.457% -62.442%] (p = 0.00 <
0.05)
Performance has improved.
Found 12 outliers among 100 measurements (12.00%)
3 (3.00%) low severe
2 (2.00%) low mild
4 (4.00%) high mild
3 (3.00%) high severe
all false int 10k time: [194.24 ns 194.25 ns 194.25 ns]
change: [-58.900% -58.838% -58.787%] (p = 0.00 <
0.05)
Performance has improved.
Found 12 outliers among 100 measurements (12.00%)
1 (1.00%) low mild
8 (8.00%) high mild
3 (3.00%) high severe
```
Counting `ns` :).
Note that this benchmark is sensitive to scale, because the filter algorithm
is `O(n)` and the fast path `O(1)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
