robert3005 commented on code in PR #52162:
URL: https://github.com/apache/arrow/pull/52162#discussion_r4224554145
##########
cpp/src/parquet/chunker_internal_test.cc:
##########
@@ -742,6 +746,13 @@ Result<int64_t> CalculateCdcSize(const
std::shared_ptr<Array>& array, bool nulla
} else if (::arrow::is_large_binary_like(type_id)) {
auto binary_array = checked_cast<const
::arrow::LargeBinaryArray*>(array.get());
result += binary_array->total_values_length();
+ } else if (::arrow::is_binary_view_like(type_id)) {
+ auto view_array = checked_cast<const
::arrow::BinaryViewArray*>(array.get());
+ for (int64_t i = 0; i < view_array->length(); i++) {
Review Comment:
Thanks, I'm pretty new to this codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]