sdf-jkl commented on code in PR #11302:
URL: https://github.com/apache/arrow-rs/pull/11302#discussion_r4220247331
##########
parquet-variant-compute/src/type_conversion.rs:
##########
@@ -424,8 +422,10 @@ where
precision,
scale,
),
- Variant::Float(f) => single_float_to_decimal::<O>(<f64 as
From<f32>>::from(*f), mul),
- Variant::Double(f) => single_float_to_decimal::<O>(*f, mul),
+ Variant::Float(f) => {
+ float_to_decimal::<O>(<f64 as From<f32>>::from(*f), precision,
scale).ok()
Review Comment:
I think the prime suspect for causing the regression for `variant-cast` is
error string allocation we introduce here, because `single_float_to_decimal`
doesn't return `Result`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
