sdf-jkl opened a new pull request, #11476: URL: https://github.com/apache/arrow-rs/pull/11476
# Which issue does this PR close? Related to #11166. # Rationale for this change The existing unused-dependency checks add 54 Clippy invocations across Arrow crates and exclude tests and benchmarks. Replace them with cargo-shear to check dependencies across the repository, including dev-dependencies and Parquet crates. A separate Machete comparison draft evaluates detection quality and false positives on the same upstream base. Dependencies remain unchanged so the PR CI runs show each tool's findings directly. # What changes are included in this PR? - Add a job using cargo-shear 1.14.0 with `--deny-warnings`, covering the workspace and both excluded PyArrow crates. The excluded-crate scans still run if an earlier scan finds issues. - Remove the 54 dependency-only Clippy invocations and preserve all 18 regular Clippy checks. - Use the same SHA-pinned checkout and tool installer actions as the existing workflows. - Change only the two workflow files. Findings fail the job without applying fixes or adding ignores; merge requirements are unchanged. # Are these changes tested? `actionlint`, `git diff --check`, and `typos --config typos.toml` pass. On upstream base `e17d04788f`, all three local Shear scans pass with no findings. Machete 0.9.2 reports six false positives on that same base: `bytes`, `futures`, and `tokio` in each of `arrow-csv` and `arrow-json`, all used in reader doctests. The previously observed unused and misplaced dependencies have already been corrected upstream. This PR contains no dependency cleanup. The PR CI run will validate installation and execution in GitHub Actions. Codex assisted with the workflow edits, local validation, and this description. # Are there any user-facing changes? No. This changes CI only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
