etseidl commented on code in PR #11475:
URL: https://github.com/apache/arrow-rs/pull/11475#discussion_r4232587801
##########
parquet/tests/arrow_reader/page_index.rs:
##########
@@ -428,7 +428,7 @@ fn test_page_index_sizes() {
let metadata = reader.finish().unwrap();
assert!(metadata.page_index().is_some());
#[cfg(not(feature = "encryption"))]
- assert_eq!(metadata.memory_size(), 11326);
+ assert_eq!(metadata.memory_size(), 8310);
#[cfg(feature = "encryption")]
- assert_eq!(metadata.memory_size(), 11750);
+ assert_eq!(metadata.memory_size(), 8734);
Review Comment:
The added `Arc`s lead to some bloat for a fully populated index, but down
here for a small subset the reduced storage overhead wins big.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
