hpaliwal8 commented on issue #1364: URL: https://github.com/apache/arrow-go/issues/1364#issuecomment-6085635003
Confirmed on main at b02cc011 (Go 1.26.0, darwin/arm64): `NewFileReader` opens a one-row dictionary file, while `NewMappedFileReader` panics with `assignment to entry in nil map`. The constructor change looks sufficient: initialize `memo` with `dictutils.NewMemo()` in `NewMappedFileReader`, matching `NewFileReader`. I plan to add a focused mapped-reader regression that checks construction and `RecordBatchAt(0)` against the written dictionary record, using a checked allocator to catch cleanup errors. I'll keep the existing `TestMappedReader` buffer-pointer assertions intact. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
