Rich-T-kid commented on PR #11463: URL: https://github.com/apache/arrow-rs/pull/11463#issuecomment-6085462531
>> similar thing here seems pretty minor but is reproducible across multiple runs > Yeah, I've tried this pattern before elsewhere, and always gave up because the improvement never overrode the lingering safety concerns. This otherwise looks correct, so your call @Rich-T-kid on whether you want to continue with this one. Seems like the big win is https://github.com/apache/arrow-rs/pull/11462. 🤔 im leaning towards not keeping it. only because it relys on ` decoder.get_batch(dst)?` to do exactly as we expect it to today. in the future if someone changes the code and forgets to update this code as well, we will have a very hard bug to trace down. maybe if the perf wins were 10-15% I would feel different. neat idea & I may come back to this in the future but ill close it for now, thanks @etseidl -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
