mightsleep commented on code in PR #11322: URL: https://github.com/apache/arrow-rs/pull/11322#discussion_r4234559858
########## arrow-buffer/src/util/bit_util.rs: ########## @@ -51,8 +51,11 @@ use crate::bit_chunk_iterator::BitChunks; /// assert_eq!(compress(0b1011_0100, 0b0110_1101), 0b0000_1010); /// ``` // -// Replace with `value.compress(mask)` when `uint_gather_scatter_bits` is -// stabilised: <https://github.com/rust-lang/rust/issues/149069> +// When `uint_gather_scatter_bits` is stabilised +// (<https://github.com/rust-lang/rust/issues/149069>), measure +// `value.compress(mask)` against this before switching: its portable +// version is the constant-time network, which the fallback here beats on Review Comment: reworded -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
