A5rocks commented on issue #32609: URL: https://github.com/apache/arrow/issues/32609#issuecomment-6092643016
I also agree that in-source type hints would be ideal. I don't know pyarrow's particulars, but I've looked at e.g. pandas stubs and was surprised about the policies there (e.g. removing deprecated functions, having some functions take in the wrong parameter -- e.g. be documented as taking in a date-like object then being typed as taking a `datetime.date`, when anything `pd.Timestamp` would accept would work). I think having types next to the code in question helps keep them sync with the docs and generally more accurate. I also think that libraries should not change their types to support more typecheckers, assuming they're unambiguously correct -- for a library I maintain, I've simply created upstream issues and linked to them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
