adriangb opened a new pull request, #11487: URL: https://github.com/apache/arrow-rs/pull/11487
# Which issue does this PR close? - Part of https://github.com/apache/arrow-rs/issues/11234. # Rationale for this change In `FetchGranularity::Batch` (https://github.com/apache/arrow-rs/pull/11238), the decoder reads one output batch from a read plan and then calls `next` one more time to check that the plan is done. With row selectors, that second call decodes an empty batch of each column. # What changes are included in this PR? This PR is stacked on https://github.com/apache/arrow-rs/pull/11238 and is a draft until it merges. The change of this PR alone is [one commit, +102 lines](https://github.com/pydantic/arrow-rs/compare/e06d67cf50...3a0d705623). - `ParquetRecordBatchReader::is_exhausted` (`pub(crate)`): `true` if the read plan has no rows left. - The batch-mode output step calls `next` a second time only if the plan is not exhausted. # Are these changes tested? Yes: `test_is_exhausted_after_the_last_selected_row` and `window_plan_is_exhausted_after_its_rows`. The harness from https://github.com/apache/arrow-rs/pull/11485 checks that the output does not change. I have no benchmark result for this PR yet. `push_decoder/decode/batch` from https://github.com/apache/arrow-rs/pull/11238 covers it. # Are there any user-facing changes? No. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
