Phoenix500526 opened a new issue, #11490: URL: https://github.com/apache/arrow-rs/issues/11490
The current RAT check accepts a Rust file even when the first three lines of its ASF license header are removed. RAT 0.13 still marks the file as approved, and `dev/release/run-rat.sh` exits successfully. `dev/release/check-rat-report.py` checks RAT's license approval result, so it cannot detect this incomplete header. ### To reproduce 1. Copy a Rust source file with a complete ASF header to a temporary directory. 2. Remove the first three lines of its ASF header from the copy. 3. Run `dev/release/run-rat.sh` against that directory. 4. The script reports no unapproved licenses and exits with status 0. ### Expected behavior CI should fail when an ASF-owned file has an incomplete license header. In particular, removing the first three header lines from a Rust file should make the header check fail. ### Possible approach DataFusion addressed the same class of problem by adding HawkEye: https://github.com/apache/datafusion/pull/12008. We could evaluate HawkEye for checking the expected header text, with appropriate coverage and exceptions for arrow-rs files, while retaining RAT for the broader release license audit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
