efegokdemir commented on code in PR #11209:
URL: https://github.com/apache/arrow-rs/pull/11209#discussion_r4237013272
##########
arrow-data/src/transform/mod.rs:
##########
@@ -843,6 +843,16 @@ impl<'a> MutableArrayData<'a> {
));
}
+ if len == 0 {
+ return Ok(());
+ }
+
+ if matches!(&self.data.data_type, DataType::Union(fields, _) if
fields.is_empty()) {
Review Comment:
Hey, I understand where you're both coming from, and I want to be a bit more
open about this.
A couple of weeks ago, I was relying on AI quite heavily, including for
writing some of my comments. I've been trying to change that recently, using it
less, slowing down on PRs, and spending more time understanding the code and
feedback myself.
Looking back, I can see why some of my replies gave the wrong impression.
The Cargo comment in particular was something I should've caught before
posting. That's on me.
I was honestly disappointed when the PR was initially closed, especially
since I've been trying to improve how I contribute. But I also understand why
you had concerns.
I'm not here to just pass AI output to maintainers. I genuinely want to
contribute, learn, and get better at this. I know that takes more than just
saying it, though.
Thanks for taking the time to explain your perspective and review my work. I
do appreciate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
