haohuaijin commented on code in PR #11498:
URL: https://github.com/apache/arrow-rs/pull/11498#discussion_r4237138144
##########
parquet/benches/row_selection_cursor.rs:
##########
@@ -46,10 +46,6 @@ struct DataProfile {
}
const DATA_PROFILES: &[DataProfile] = &[
- DataProfile {
- name: "int32",
- build_batch: build_int32_batch,
- },
Review Comment:
remove `dtype/int32`, as it is already conver by the `uniform50` cases in
below loop
https://github.com/apache/arrow-rs/blob/081260215f5a1f4260d83213dc4598e5c63c950e/parquet/benches/row_selection_cursor.rs#L156-L168
##########
parquet/benches/row_selection_cursor.rs:
##########
@@ -34,9 +34,9 @@ use rand::{RngExt, SeedableRng};
const TOTAL_ROWS: usize = 1 << 20;
const BATCH_SIZE: usize = 1 << 10;
const BASE_SEED: u64 = 0xA55AA55A;
-const AVG_SELECTOR_LENGTHS: &[usize] = &[4, 8, 12, 16, 20, 24, 28, 32, 36, 40];
-const COLUMN_WIDTHS: &[usize] = &[2, 4, 8, 16, 32];
-const UTF8VIEW_LENS: &[usize] = &[4, 8, 16, 32, 64, 128, 256];
+const AVG_SELECTOR_LENGTHS: &[usize] = &[4, 28, 32, 40];
+const COLUMN_WIDTHS: &[usize] = &[2, 8, 32];
+const UTF8VIEW_LENS: &[usize] = &[8, 16, 256];
Review Comment:
`AVG_SELECTOR_LENGTHS`: keep the 4 for fragment case, and 28, 32, 40 for the
default auto threshold 32.
`COLUMN_WIDTHS`: remove the middle value 4, 16
`UTF8VIEW_LENS`: keep 8 as the short case, 16 as the first tested length
above Utf8View’s 12-byte inline limit, the 256 as longest case
##########
parquet/benches/row_selection_cursor.rs:
##########
@@ -253,7 +249,13 @@ fn bench_over_lengths(
}
}
-criterion_group!(benches, criterion_benchmark);
+criterion_group! {
+ name = benches;
+ config = Criterion::default()
+ .warm_up_time(std::time::Duration::from_secs(2))
+ .sample_size(50);
+ targets = criterion_benchmark
+}
Review Comment:
reduce the warm_up time from 3s to 2s and sample size from 100 to 50
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
