Jefffrey commented on code in PR #11479:
URL: https://github.com/apache/arrow-rs/pull/11479#discussion_r4242288631
##########
arrow-arith/src/numeric.rs:
##########
@@ -1133,14 +1136,15 @@ fn decimal_op<T: DecimalType>(
),
};
+ // On overflow, `mul_checked` would build an `ArrowError` for the
fallback to discard
Review Comment:
```suggestion
```
personally id omit this, seems apparent enough that we dont need to mention
previous behaviour
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
