alamb commented on code in PR #11485: URL: https://github.com/apache/arrow-rs/pull/11485#discussion_r4243147727
########## parquet/src/arrow/push_decoder/equivalence_tests.rs: ########## Review Comment: I feel like this could be called a fuzz test almost ########## parquet/src/arrow/push_decoder/mod.rs: ########## @@ -18,6 +18,8 @@ //! [`ParquetPushDecoder`]: decodes Parquet data with data provided by the //! caller (rather than from an underlying reader). +#[cfg(test)] Review Comment: Can I convince you to put this as part of the arrow_reader test rather than its own test only module? https://github.com/apache/arrow-rs/tree/main/parquet/tests/arrow_reader That will keep the code easier to discover I think -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
