Copilot commented on code in PR #50407:
URL: https://github.com/apache/arrow/pull/50407#discussion_r4245397091
##########
cpp/src/arrow/flight/transport/grpc/util_internal.h:
##########
@@ -107,6 +97,10 @@ ARROW_FLIGHT_EXPORT
::grpc::Status ToGrpcStatus(const Status& arrow_status,
::grpc::ServerContext* ctx = nullptr);
+ARROW_FLIGHT_EXPORT
+::grpc::Status ToGrpcStatus(const Status& arrow_status,
+ ::grpc::CallbackServerContext* ctx);
Review Comment:
This overload is compiled unconditionally, but Arrow still supports gRPC
1.27+ while `GRPC_ENABLE_ASYNC` is only enabled from 1.40 onward
(`cpp/src/arrow/flight/CMakeLists.txt:164-167`). Older gRPC headers do not
provide `CallbackServerContext`, so the synchronous build fails when compiling
this signature. Guard the callback-context declaration and definition with the
same version/async condition (or provide a compatible abstraction).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
