CurtHagenlocher opened a new pull request, #4883:
URL: https://github.com/apache/arrow-adbc/pull/4883
## What's changed
DuckDB 1.5 adds support for ADBC 1.1. This upgrades the DuckDB used by the
C# tests to 1.5.6 and adds tests for the ADBC 1.1 APIs that the C# importer
currently exposes:
- `StatementExecuteSchema`: checks the returned schema against the actual
result schema, and that `ExecuteSchema` doesn't execute the statement (`INSERT
... RETURNING` inserts no rows).
- `ConnectionCancel` / `StatementCancel`: cancelling while idle is harmless,
and cancelling a long-running query interrupts it.
### Fetching DuckDB
`DuckDB.NET.Bindings.Full` 1.5.x no longer targets `netstandard2.0`, so a
`PackageReference` fails to restore for net472. The tests (and Benchmarks) only
use the native library from the package, so it's now fetched with
`PackageDownload`, which skips the framework compatibility check. The version
lives in a `DuckDbVersion` property in `Directory.Packages.props`. As a result,
all target frameworks now test against the same DuckDB version.
`PackageDownload` didn't restore when its version came from central package
management, which is why the version is a property instead. Dependabot probably
won't update it.
### Notes
- DuckDB reports a cancelled query as `ADBC_STATUS_INVALID_ARGUMENT`
("INTERRUPT Error: Interrupted!") rather than `ADBC_STATUS_CANCELLED`, so the
cancel tests check the message.
- `GetOption` and typed `SetOption` aren't yet exposed by the C# importer,
so they're not tested here. That will be a follow-up PR.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
