CurtHagenlocher commented on code in PR #4884:
URL: https://github.com/apache/arrow-adbc/pull/4884#discussion_r4254708737
##########
csharp/src/Apache.Arrow.Adbc/C/CAdbcDriverImporter.cs:
##########
@@ -340,9 +340,16 @@ public unsafe override AdbcDatabase
Open(IReadOnlyDictionary<string, string> par
{
if (result == null && nativeDatabase.private_data != null)
{
- using (CallHelper caller = new CallHelper())
+ // Don't let a failed release hide the error that got
us here
+ try
+ {
+ using (CallHelper caller = new CallHelper())
+ {
Review Comment:
Good catch, thanks. Fixed in a2f3a62e6: the object-valued overload now
releases the native database on failure, using the same cleanup as the
string-valued one. The cleanup test now covers both overloads and checks that
the release happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
